Re: [RFC] use pci_find_ext_capability everywhere

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Friday, October 3, 2008 7:50 am Matthew Wilcox wrote:
> On Thu, Oct 02, 2008 at 11:50:24AM -0700, Jesse Barnes wrote:
> > +++ b/drivers/pci/pcie/aer/aerdrv.c
> > @@ -105,7 +105,7 @@ static irqreturn_t aer_irq(int irq, void *context)
> >  	unsigned long flags;
> >  	int pos;
> >
> > -	pos = pci_find_aer_capability(pdev->port);
> > +	pos = pci_find_ext_capability(dev, PCI_EXT_CAP_ID_ERR);
> >  	/*
> >  	 * Must lock access to Root Error Status Reg, Root Error ID Reg,
> >  	 * and Root error producer/consumer index
>
> Waitaminute ... you didn't actually compile this, did you?  pdev changes
>
> to dev in three other hunks:

Doh!  You caught me. :)  That's why I was careful to put [RFC] rather than 
[PATCH] on the subject.

But since you're looking... I'll respin and include a change to do something 
similar to get_port_device_capability(), please check it out when you get a 
chance.

Jesse
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux