On Fri, Sep 26, 2008 at 04:36:41PM -0700, Arjan van de Ven wrote: > A common thing in many PCI drivers is to ioremap() an entire bar. > This is a slightly fragile thing right now, needing both an address and a size, > and many driver writers do.. various things there. > > This patch introduces an ioremap_pcibar() function taking just a PCI device struct > and the bar number as arguments, and figures this all out itself, in one place. > In addition, we can add various sanity checks to this function (the patch already > checks to make sure that the bar in question really is a MEM bar; few to no drivers > do that sort of thing). So we already have a pci_iomap() which takes a 'max' argument. If you make 'max' -1, don't you get this same behaviour? -- Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
