Re: Removing CONFIG_PCI_MSI choice

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Sep 19, 2008 at 10:33:16AM -0700, Benjamin Herrenschmidt wrote:
> 
> > What I thought we agreed on last night was:
> > 
> >  - Add support to the PCI core to let drivers report "I didn't get an
> >    MSI, suspect this machine to be broken" (patches already floating around,
> >    need one last push to get them merged).
> >  - Add support to storage drivers to use that facility, in particular
> >    AHCI.
> >  - Turn this on by default in Fedora, wait for kerneloops to pick up
> >    all the PCI hierarchy traces
> >  - Update the blacklists in the kernel
> >  - Remove the PCI_MSI config option
> >  - Remove the per-driver 'nomsi' options
> 
> The question remains about the need to have the config option in the
> first place. I would say the answer is yes, at least for a little while,
> for the sake of not being burned alive by embedded people...
> 

How about just moving the config option to be under CONFIG_EMBEDDED
for the short-term? (Although, I really don't think CONFIG_PCI_MSI
contributes anything significant to the kernel size.)

[x86_64]
   text	   data	    bss	    dec	    hex	filename
6816871	 994760	 668412	8480043	 81652b	vmlinux.msi
6786743	 993952	 668284	8448979	 80ebd3	vmlinux.notmsi

Kind of meh...

I think it's a good idea to turn it on everywhere, and just twiddle
the bit on or off. Then again, it would probably be better to just
enable it everywhere and hope someone will fix the myriad of bugs.

That's probably wishful thinking though. ;-)

r, Kyle
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux