* Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx> wrote: > On Friday, June 13, 2008 12:06 pm Matthew Wilcox wrote: > > On Fri, Jun 13, 2008 at 12:01:13PM -0700, Jesse Barnes wrote: > > > commit 7bcbc78dea92fdf0947fa48e248da3c993a5690f > > > Author: Neil Horman <nhorman@xxxxxxxxxxxxx> > > > Date: Wed Jan 30 13:31:26 2008 +0100 > > > > > > x86: clean up arch/x86/kernel/early-quirks.c > > > > > > clean up checkpatch errors. No code changed. > > > > Clearly a lie. Do we need people to do objdump-based compares of > > source code before they're allowed to claim this in future? > > Yeah, maybe checkpatch.pl should include that in its output, "Be sure > the md5sums of the code & data match before you claim things are > identical". :) yeah, and we normally do that - see commits 97b44ae6cd8 or 177773ed87. The cleanup intent from Neil was good in principle: the early_quirks() function was too large and the introduction of check_dev_quirk() improved readability. Btw., did this mistake cause any actual regression or misbehavior? The commit is rather old and i dont remember anything seriously blowing up due to this. (we had another far more serious bug in this area) Also, i have to say that Matthew Wilcox got quite a bit carried away by characterising the commit a "lie" - this was not a lie (which needs intent), but a simple mistake. Otherwise this statement in a commit from Matthew Wilcox would be a "lie" as well: | commit 64ac24e738823161693bf791f87adc802cf529ff | Author: Matthew Wilcox <matthew@xxxxxx> | Date: Fri Mar 7 21:55:58 2008 -0500 | | Generic semaphore implementation | | Semaphores are no longer performance-critical, [...] as semaphores were clearly performance-critical, as witnessed by commit bf726eab3711c. So please lets stop calling people such names, it's silly and counterproductive. Bugs happen and cleanups are good in general. Cleanups can be embarrasing because they show how much we sucked in the past, but lets get over that aspect of it and lets stop being negative about them. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
