Michael Ellerman wrote: > Yeah I guess, I like __weak better than the attribute mess though. I'm not good at attributes, but few minutes ago I found: [include/linux/compiler-gcc.h] #define __weak __attribute__((weak)) ...Yeah, I like this too. >> There was violation of 80 column limit, even though it was 81. >> The name "base" is a bit confusing because it does not equal to mask_base, >> so I employ "ofs" as offset of the entry. > > I guess base != mask_base is fair enough, except "ofs" doesn't mean > anything. If you want it be short for offset it needs to be "offs" I > think, which breaks 80 columns again :) Hum, then I'll get back "base" and just break the line... (Are there any idea?) Thanks, H.Seto -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html