Michael Ellerman wrote: > On Wed, 2008-06-04 at 13:52 +0900, Hidetoshi Seto wrote: >> We never have MSI-X's msi_desc in msi_list while MSI is enabled >> (and vise versa). > > You're probably right, but that's not all you're removing. There's also > the !entry->dev check - which is probably also safe to remove, but if it > breaks you get both pieces :) Still, your changelog should mention > that. You are right. And the !entry->dev check is also safe to remove, since attached entry always have proper reference. Or it would be better to put BUG_ON(!entry->dev) instead of silence returning. Jesse, could you add my mention above (And~) to the description of this patch when you apply it to your git tree? Or do I need to resend updated one? Thanks, H.Seto -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
