Re: [PATCH 5/7] pci hotplug core: add check of duplicate slot name

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 30, 2008 at 08:15:21AM +1000, Benjamin Herrenschmidt wrote:
> On Thu, 2008-05-29 at 13:15 -0600, Matthew Wilcox wrote:
> > that's for the slot.  Is there a property on the slot's OF node that
> > would tell us the devfn (ok, not the 'fn' part, but YKWIM)?
> 
> There is no of node for a slot. At best you get the bridge above. So you
> pretty much don't know, at least not using standard properties. There
> might be a way to figure it out in a dodgy platform specific way but I
> wouldn't bet on it.

Well, that sucks.  Even AIX has no way to find this out?  Really?

> In fact, you don't necessarily have the bridge either.
> 
> When you do hotplug operations on pSeries, the hypervisor feeds us with
> a whole bunch of new OF nodes & properties -at the time of the
> insertion-. This can include new top level host bridges, and layers of
> p2p bridges finally leading to the device that was inserted.

But surely you get a series of events?

"Hi, I've just plugged in a new cabinet"
"Hi, I've just plugged in a new PCI root bridge"
"Hi, I've just plugged in a new PCI-PCI bridge"
"Hi, I've just plugged in a new PCI card"

> That is at least when you move things in and out of partitions. I have
> to verify what happens if you add to a partition an empty slot (if you
> can) and then just perform insert/remove operations on it. I'm not the
> expert in IBM PCI hotplug stuff, and when I tried to sort that out 3
> weeks ago, I just didn't manage to get the bloody thing to work at all
> on one of my test machines (the daemon talking to the management console
> is ... fragile).

Surely you must be able to, or we wouldn't encounter a problem.

> We have an LTC team that should be maintaining that whole hotplug stuff
> so I'm trying to get them involved in this discussion.

It would be good to hurry this up.  The patches have been around for
months.

-- 
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux