Re: [PATCH 5/7] pci hotplug core: add check of duplicate slot name

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 29, 2008 at 12:50:20PM -0600, Alex Chiang wrote:
> So by the time we get to pci_hp_register(), we must have a pci_bus for
> the hotplug slot we're registering. The only thing we're missing for the
> new pci_hp_register() interface is a slotno.
> 
[...]
> 
> Basically, for populated slots, we can get the PCI_SLOT() of the
> ->child, and for unpopulated slots, we just use 0 as a placeholder.

I was thinking "That seems pretty dodgy".  But it seems to be what the
driver does now in address_read_file():

        if (bus->self)
                retval = sprintf(buf, pci_name(bus->self));
        else
                retval = sprintf(buf, "%04x:%02x:00.0",
                        pci_domain_nr(bus), bus->number);

-- 
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux