On (22/09/24 19:20), Helge Deller wrote:
> diff --git a/arch/parisc/kernel/pdc_cons.c b/arch/parisc/kernel/pdc_cons.c
> index 3f9abf0263ee..f15998aa47a8 100644
> --- a/arch/parisc/kernel/pdc_cons.c
> +++ b/arch/parisc/kernel/pdc_cons.c
> @@ -262,8 +262,6 @@ void __init pdc_console_init(void)
> */
> void pdc_console_restart(bool hpmc)
> {
> - struct console *console;
> -
> if (pdc_console_initialized)
> return;
>
> @@ -275,8 +273,8 @@ void pdc_console_restart(bool hpmc)
> pdc_cons.flags &= ~CON_PRINTBUFFER;
>
> while (!hlist_empty(&console_list)) {
> - unregister_console(READ_ONCE(hlist_entry(console_list.first,
> - struct console, node)));
> + unregister_console(hlist_entry(console_list.first,
> + struct console, node));
In this case we maybe can use cons_first() macro here (perhaps
give it a little more clear name (first_console()?) and move to
printk.h) and also do READ_ONCE there
