On Fri, Sep 2, 2022, at 9:51 AM, Linus Walleij wrote: > This enables the parisc to use <asm-generic/io.h> to fill in the > missing (undefined) [read|write]sq I/O accessor functions. > > This is needed if parisc[64] ever wants to uses CONFIG_REGMAP_MMIO > which has been patches to use accelerated _noinc accessors > such as readsq/writesq that parisc64, while being a 64bit platform, > as of now not yet provide. > > This comes with the requirement that everything the architecture > already provides needs to be defined, rather than just being, > say, static inline functions. > > Bite the bullet and just provide the definitions and make it work. > Compile-tested on parisc32 and parisc64. Drop some of the __raw > functions that now get implemented in <asm-generic/io.h>. > > Reported-by: kernel test robot <lkp@xxxxxxxxx> > Link: > https://lore.kernel.org/linux-arm-kernel/62fcc351.hAyADB%2FY8JTxz+kh%25lkp@xxxxxxxxx/ > Cc: James E.J. Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> > Cc: Helge Deller <deller@xxxxxx> > Cc: linux-parisc@xxxxxxxxxxxxxxx > Cc: linux-arch@xxxxxxxxxxxxxxx > Cc: Mark Brown <broonie@xxxxxxxxxx> > Cc: Arnd Bergmann <arnd@xxxxxxxx> > Cc: John David Anglin <dave.anglin@xxxxxxxx> > Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx> Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx> > #include <asm-generic/iomap.h> > +/* > + * These get provided from <asm-generic/iomap.h> since parisc does not > + * select GENERIC_IOMAP. > + */ > +#define ioport_map ioport_map > +#define ioport_unmap ioport_unmap > +#define ioread8 ioread8 [nitpicking] 's/since/though/' or similar: As discussed, the asm-generic/iomap.h declarations are meant to be used with GENERIC_IOMAP, parisc just uses them anyway despite having its own abstraction. Arnd
