Re: [PATCH] parisc: Use the generic IO helpers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 1, 2022 at 2:20 PM Arnd Bergmann <arnd@xxxxxxxx> wrote:

> According to the comment, the parisc version was originally
> meant to handle additional special cases besides MMIO or
> PIO, but this seems to have never happened. The current
> version looks basically equivalent to the generic version
> to me, except for a small bug I found (see patch below).

I saw this too, but didn't know what to do with it.

I'll include your patch as two of us clearly think it looks
like a bug.

The other pecularity is that iomap and the parisc iommu
unconditionally defines and uses 64bit MMIO accessors,
so I had to quirk <asm-generic/io.h> with a special
"give me 64bit IO even though I'm 32bit" mechanism,
we can discuss this after I posted v2.

> Changing parisc to GENERIC_IOMAP is clearly something we
> can do, but I agree that it would be out of scope for
> your series.

That's for later :)

Yours,
Linus Walleij



[Index of Archives]     [Linux SoC]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux