Re: [PATCH] parisc: Use the generic IO helpers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 1, 2022 at 9:35 AM Arnd Bergmann <arnd@xxxxxxxx> wrote:

> >  #include <asm-generic/iomap.h>
> > +/* These get provided from <asm-generic/iomap.h> */
> > +#define ioport_map ioport_map
> > +#define ioport_unmap ioport_unmap
> > +#define ioread8 ioread8
> > +#define ioread16 ioread16
> > +#define ioread32 ioread32
> > +#define ioread16be ioread16be
> > +#define ioread32be ioread32be
> > +#define iowrite8 iowrite8
> > +#define iowrite16 iowrite16
> > +#define iowrite32 iowrite32
> > +#define iowrite16be iowrite16be
> > +#define iowrite32be iowrite32be
> > +#define ioread8_rep ioread8_rep
> > +#define ioread16_rep ioread16_rep
> > +#define ioread32_rep ioread32_rep
> > +#define iowrite8_rep iowrite8_rep
> > +#define iowrite16_rep iowrite16_rep
> > +#define iowrite32_rep iowrite32_rep
>
> You should not need these overrides here, since the
> definitions in asm-generic/io.h are only relevant
> for the !CONFIG_GENERIC_IOMAP case, i.e. architectures
> that can access port I/O through MMIO rather than
> special helper functions or instructions.

parisc does not select GENERIC_IOMAP.

Are you saying that it should?

That seems like an invasive change to me...

Fixed the rest and resending.

Yours,
Linus Walleij



[Index of Archives]     [Linux SoC]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux