On 5/17/22 20:28, Rolf Eike Beer wrote: > Am Dienstag, 17. Mai 2022, 20:11:38 CEST schrieb Helge Deller: > >> I can easily split out the pr_warn("WARNING"). > > Would make sense IMHO. I split that patch out now. Dave, can you please check if you are ok with it? https://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux.git/commit/?h=for-next&id=67c35a3b646cc68598ff0bb28de5f8bd7b2e81b3 I used the wording from your other mail. >> Moving the get_ptep() back to the original place seems ok, and I'll keep >> the strange indenting which checkpatch want. > > If its back at the original place then there is no need to change as > checkpatch will not complain on unmodified lines. I meant "back to the place where it was versions before". So, it has to move anyway now. > If it needs to be moved and > changed then I would say do it in it's own patch as well. I kept it in the way Dave sent it (with the checkpatch fixups I added). Just pushed a new "for-next" tree at the usual place: https://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux.git/log/?h=for-next Helge