On Thu, May 5, 2022 at 10:56 AM Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx> wrote: > On Wed, 4 May 2022, Arnd Bergmann wrote: > > On Wed, May 4, 2022 at 10:33 AM Ilpo Järvinen > > <ilpo.jarvinen@xxxxxxxxxxxxxxx> wrote: > > > On Wed, 4 May 2022, Arnd Bergmann wrote: > > > > On Wed, May 4, 2022 at 9:20 AM Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx> wrote: > > > > > > > > > After applying the patch locally, I still see a bunch of whitespace > > > > differences in the > > > > changed lines if I run > > > > > > > > vimdiff arch/*/include/uapi/asm/termbits.h include/uapi/asm-generic/termbits.h > > > > > > > > I think this mostly because you left the sparc version alone (it already > > > > uses hex constants), but it may be nice to edit this a little more to > > > > make the actual differences stick out more. > > > > > > I took a look on further harmonizing, however, it turned out to be not > > > that simple. This is basically the pipeline I use to further cleanup the > > > differences and remove comments if you want to play yourself, just remove > > > stages from the tail to get the intermediate datas (gawk is required for > > > --non-decimal-data): > > > > I've played around with it some more to adjust the number of leading > > zeroes and the type of whitespace. This is what I ended up with on top > > of your patch: https://pastebin.com/raw/pkDPaKN1 > > > > Feel free to fold it into yours. > > Ok thanks. With that it seems to go a bit beyond octal to hex conversion > so I'll make a series out of it. The series will also introduce > include/uapi/asm-generic/termbits-common.h for the most obvious > intersection. Ok, sounds good. Here's a retroactive Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> for my changes so you can put them into a separate patch. I assume you will change it some more in the process, so maybe retain your ownership and just mark the bits a 'Co-developed-by: Arnd...'. Arnd
