On Wed, May 4, 2022 at 9:20 AM Ilpo Järvinen
<ilpo.jarvinen@xxxxxxxxxxxxxxx> wrote:
>
> Many archs have termbits.h as octal numbers. It makes hard for humans
> to parse the magnitude of large numbers correctly and to compare with
> hex ones of the same define.
>
> Convert octal values to hex.
>
> First step is an automated conversion with:
>
> for i in $(git ls-files | grep 'termbits\.h'); do
> awk --non-decimal-data '/^#define\s+[A-Z][A-Z0-9]*\s+0[0-9]/ {
> l=int(((length($3) - 1) * 3 + 3) / 4);
> repl = sprintf("0x%0" l "x", $3);
> print gensub(/[^[:blank:]]+/, repl, 3);
> next} {print}' $i > $i~;
> mv $i~ $i;
> done
>
> On top of that, some manual processing on alignment and number of zeros.
> In addition, small tweaks to formatting of a few comments on the same
> lines.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>
Good idea!
I assume you already checked if additional file contents can be shared across
architectures? I think I've tried in the past but didn't really get
anywhere with
that.
After applying the patch locally, I still see a bunch of whitespace
differences in the
changed lines if I run
vimdiff arch/*/include/uapi/asm/termbits.h include/uapi/asm-generic/termbits.h
I think this mostly because you left the sparc version alone (it already
uses hex constants), but it may be nice to edit this a little more to
make the actual differences stick out more.
> I prefer this to go in though Greg's tty tree.
Acked-by: Arnd Bergmann <arnd@xxxxxxxx>
