Re: [PATCH 2/2] parisc: add support for TOC (transfer of control)

[Rolf Eike Beer <eike-kernel@xxxxxxxxx>]

> +void notrace toc_intr(struct pt_regs *regs)
> +{
> +	struct pdc_toc_pim_20 pim_data20;
> +	struct pdc_toc_pim_11 pim_data11;
> +
> +	nmi_enter();
> +
> +	if (boot_cpu_data.cpu_type >= pcxu) {
> +		if (pdc_pim_toc20(&pim_data20))
> +			panic("Failed to get PIM data");
> +		toc20_to_pt_regs(regs, &pim_data20);
> +	} else {
> +		if (pdc_pim_toc11(&pim_data11))
> +			panic("Failed to get PIM data");
> +		toc11_to_pt_regs(regs, &pim_data11);
> +	}
> +

You can move the variables into the if/else branches as they are not used 
outside. That would also reduce stack usage.

Eike

Attachment: signature.asc
Description: This is a digitally signed message part.