Re: [PATCH v3] parisc: Fix crash due alternative coding for NP iopdir_fdc bit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 28.05.19 17:41, Sven Schnelle wrote:
> Hi,
>
> On Tue, May 28, 2019 at 01:28:12PM +0200, Rolf Eike Beer wrote:
>>> FWIW, i hacked up a small driver to read the firmware, i'm attaching it
>>> to this
>>> Mail. Would be nice if some people could try reading the firmware from
>>> their PA-RISC
>>> system so we can collect and archive them. Note that it HPMC's in 32 Bit
>>> Mode,
>>> but it worked in 64 Bit mode on my C3750/J5000.
>>
>> Nice!
>> [..]
>> Any particular reason you are not simply using BIN_ATTR_RO?
>
> The reason is just my missing experience with Kernel APIs. If anyone says such
> a driver is helpful in the upstream kernel, we could clean it up. But for now
> i just wanted to get the contents of the flash, no matter how nice the code is
> :-)

I think it's helpful, and I'm happy to include it if someone cleans it up :-)
I suggest to let it build by default (but as module).
Helge




[Index of Archives]     [Linux SoC]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux