Re: [RFC][PATCH] parisc: Fix left-shift assembly to be PA1.1 compatible

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2018-10-19 2:26 AM, Helge Deller wrote:
If it's bogus we could replace in entry.S:

--- a/arch/parisc/kernel/entry.S
+++ b/arch/parisc/kernel/entry.S
@@ -426,8 +426,7 @@
         ldw,s           \index(\pmd),\pmd
         bb,>=,n         \pmd,_PxD_PRESENT_BIT,\fault
         dep             %r0,31,PxD_FLAG_SHIFT,\pmd /* clear flags */
-       copy            \pmd,%r9
-       SHLREG          %r9,PxD_VALUE_SHIFT,\pmd
+       SHLREG          \pmd,PxD_VALUE_SHIFT,\pmd
I hadn't realized this macro was using r9 (t1).  Generally, I passed the temporary registers used by a
macro in the argument list so it was clear what registers were being used.

I believe the copy is unnecessary.

I believe the shl macro can be removed.  It is same as shlw assemble mnemonic.

Dave

--
John David Anglin  dave.anglin@xxxxxxxx




[Index of Archives]     [Linux SoC]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux