Re: [PATCH] parisc: convert /proc/pdc/{lcd,led} to seq_file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 2009-11-28 at 12:25 +0300, Alexey Dobriyan wrote:
> On Fri, Nov 27, 2009 at 11:13:54PM -0700, Grant Grundler wrote:
> > On Fri, Nov 27, 2009 at 09:51:12AM +0300, Alexey Dobriyan wrote:
> > > Signed-off-by: Alexey Dobriyan <adobriyan@xxxxxxxxx>
> > 
> > No commit comment?
> 
> No, subject says it's all.

He means rationale ... the output of the files you are altering is fixed
size and atomic, so we don't need seq_file for fear of running off the
fixed buffer and the data is reasonably fast changing, so anyone looking
to seek within the file because they can't read the data in one go isn't
going to get sensible results.  Given that, why bother with the
conversion?

James


--
To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux SoC]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux