Re: [PATCH] parisc: convert /proc/pdc/{lcd,led} to seq_file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Nov 27, 2009 at 11:13:54PM -0700, Grant Grundler wrote:
> On Fri, Nov 27, 2009 at 09:51:12AM +0300, Alexey Dobriyan wrote:
> > Signed-off-by: Alexey Dobriyan <adobriyan@xxxxxxxxx>
> 
> No commit comment?

No, subject says it's all.

> > -	ent = create_proc_entry("led", S_IFREG|S_IRUGO|S_IWUSR, proc_pdc_root);
> > +	ent = proc_create_data("led", S_IRUGO|S_IWUSR, proc_pdc_root,
> > +				&led_proc_fops, (void *)LED_NOLCD); /* LED */
> 
> Documentation/filesystems/seq_file.txt says to use create_proc_entry().
> I couldn't find any documentation on proc_create_data().
> Is this really the preferred API?

Yes, it's slightly less racy than create_proc_entry().

create_proc_entry() is going to be removed in fact.
--
To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux SoC]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux