Re: [PATCH] fix ldcw inline assembler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 01, 2009 at 05:37:18PM -0400, John David Anglin wrote:
> On Fri, 01 May 2009, Carlos O'Donell wrote:
> 
> > Historical note...
> > 
> > We clobber all of memory in userspace, like this:
> > ~~~
> > #define __ldcw(a) \
> > ({                                                                      \
> >   unsigned int __ret;                                                   \
> >   __asm__ __volatile__("ldcw 0(%1),%0"                                  \
> >                        : "=r" (__ret) : "r" (a) : "memory");            \
> >   __ret;                                                                \
> > })
> > ~~~
> > I wonder if I should change that to match the kernel?
> 
> The above is perfectly safe.  I believe the kernel provides a memory
> barrier when necessary.  There's a discussion somewhere in the mail
> archives.
> 

I, er, don't think we do, not for the spinlock primitives at least, as
far as I can tell...

regards, Kyle
--
To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux SoC]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux