James Bottomley wrote: > On Tue, 2009-01-06 at 12:57 +0100, Helge Deller wrote: >> - convert a few "if (xx) BUG();" to BUG_ON(xx) > > This is fine > >> - remove a few printk()s, as we get a backtrace with BUG_ON() anyway > > This is less helpful. Each of the printks explains why the bug > triggers. In theory you can work this out from the BUG_ON line number, > but *only* if your source files match those of the reporter, which isn't > the case in an annoyingly large number of bug reports ... speaking as > someone who seems to get to diagnose large numbers of bugs, it makes my > life harder. I fully understand your point. Regarding arch/parisc/kernel/pci-dma.c: - each of the pa11_dma_map_* functions where I removed the printks only had one BUG() anyway. Should be easy to find it in backtraces. - a few of the pa11_dma_map_* functions have printks, the others don't. I just made it consistent. Regarding arch/parisc/mm/init.c: - setup_bootmem() is a huge function. I agree that keeping this printk would make sense. So, would you be OK with the patch if I drop the init.c change and keep the pci-dma.c changes? Helge -- To unsubscribe from this list: send the line "unsubscribe linux-parisc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
