On Tue, 2009-01-06 at 12:57 +0100, Helge Deller wrote: > - convert a few "if (xx) BUG();" to BUG_ON(xx) This is fine > - remove a few printk()s, as we get a backtrace with BUG_ON() anyway This is less helpful. Each of the printks explains why the bug triggers. In theory you can work this out from the BUG_ON line number, but *only* if your source files match those of the reporter, which isn't the case in an annoyingly large number of bug reports ... speaking as someone who seems to get to diagnose large numbers of bugs, it makes my life harder. James -- To unsubscribe from this list: send the line "unsubscribe linux-parisc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html