James Bottomley wrote:
On Fri, 2008-06-06 at 22:35 +0200, Krzysztof Helt wrote:
On Thu, 05 Jun 2008 17:26:54 -0500
James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> wrote:
I'm really not sure this is such a good idea. pci_map_rom() can do an
ioremap() on the region. In that case, gsc_readl which punches through
our virtual memory into physical I/O space will fail. What assurance do
we have that all STI roms are correctly set up so pci_map_rom() isn't
inclined to ioremap them?
I haven't thought about this. The ROM the Helge tested was obviously
set up correctly, otherwise reading the ROM signature would be impossible.
I suspect Helge only tested GSC based cards, which will work just fine
because they use the old logic.
No, tested on Tadpole Laptop (7100LC) and c3k with VisEG PCI.
But it's OK that the patch was dropped...
Helge
--
To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
