On Sat, Jun 07, 2008 at 11:08:36AM +0200, Krzysztof Helt wrote: ... > I am forwarding it to the reporter of the bug 9425 as this bug should be > closed without changing the code. Actually, we should change the code: add a comment that summarizes jejb's feedback (and the rest of the conversation) so we don't repeat this exercise again in 2 years. thanks, grant > > A very similar case is for the bug 9424. I analyzed code for the Matrox > framebuffers and it is not worth changing. The idea behind the pci_map_rom() > is that it enables and maps the ROM area. The Matrox framebuffer has > these two separated as the ROM may appear in the already mapped area. > The ROM is always enabled but not always mapped. > > The only unification I see is to export pci_rom_enable/pci_rom_disable() > and use them inside the Matrox and sticore drivers (so no ioremap() > is done but the code is shorter). > > Regards, > Krzysztof > > ---------------------------------------------------------------------- > Tanie rozmowy! > Sprawdz >>> http://link.interia.pl/f1e22 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-parisc" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-parisc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
