Re: [bug] gcc-4.3 miscompiling causing networking to bugger up

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, May 31, 2008 at 12:10 AM, Kyle McMartin <kyle@xxxxxxxxxxx> wrote:
> I've found the solution to the bug, it seems something is going wonky
> because of ip_fast_csum missing a "memory" clobber.

Great news!

The asm does advance the iph pointer, and reads the header data
without telling gcc. The input/output operands only state the pointer
may be read and modified not the memory at the pointer.

The compiler may have cached iph writes in registers and they may not
be in memory yet. Under normal circumstances I would say "Add a memory
input operand for the header data e.g. "m" (*header_struct_pointer)",
but the relationship with ihl and iph is not known the compiler. In
this case it is probably correct to use the "memory" clobber as a
catch all.

Cheers,
Carlos.
--
To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux SoC]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux