Re: [bug] gcc-4.3 miscompiling causing networking to bugger up

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 28, 2008 at 08:07:00PM -0400, Carlos O'Donell wrote:
> On Wed, May 28, 2008 at 8:02 PM, Kyle McMartin <kyle@xxxxxxxxxxx> wrote:
> > I tried 4.4 from svn a few days (more like 2 weeks maybe) ago. Is that
> > recent enough or should I try 4.3-head as well (no problem to do.)
> 
> Yes, please try 4.3-head.
> 

I've found the solution to the bug, it seems something is going wonky
because of ip_fast_csum missing a "memory" clobber.

This should fix it, but I have no idea whether this is a legitimate bug,
or masking a problem with gcc due to too much inlining.

diff --git a/include/asm-parisc/checksum.h b/include/asm-parisc/checksum.h
index cc3ec1b..1916ebe 100644
--- a/include/asm-parisc/checksum.h
+++ b/include/asm-parisc/checksum.h
@@ -65,7 +65,7 @@ static inline __sum16 ip_fast_csum(const void *iph, unsigned int ihl)
 "2:\n"
 	: "=r" (sum), "=r" (iph), "=r" (ihl)
 	: "1" (iph), "2" (ihl)
-	: "r19", "r20", "r21" );
+	: "r19", "r20", "r21", "memory" );
 
 	return (__force __sum16)sum;
 }
--
To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux SoC]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux