Re: Yet another ccio fix idea?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2008-03-09 at 13:55 +0000, Joel Soete wrote:
> Hello Grant,
> 
> Always tracking this ccio-dma bug, I figure out this stuff could be helpfull:
> --- a/drivers/parisc/ccio-dma.c	2008-03-09 12:55:00.000000000 +0000
> +++ b/drivers/parisc/ccio-dma.c	2008-03-09 12:55:21.000000000 +0000
> @@ -802,7 +802,7 @@
>   			 * Hopefully someone figures out how to patch (NOP) the
>   			 * FDC/SYNC out at boot time.
>   			 */
> -			asm volatile("fdc %%r0(%0)" : : "r" (pdir_ptr[7]));
> +			asm volatile("fdc %%r0(%0)" : : "r" (pdir_ptr));

That's the wrong fix.  What it's trying to do is flush the write made
above this to pdir_ptr[7].  Therefore there should be an '&' in front,
so

asm volatile("fdc %%r0(%0)" : : "r" (&pdir_ptr[7]))

Flushing pdir_ptr may or may not work depending on the cache line width
(pdr_ptr[7] is 28 bytes away, so if the line size is 16 it will fail;
although I think almost every machine with a ccio has a 32 byte or
higher cache line width).

James


--
To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux SoC]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux