Re: Yet another ccio fix idea?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > On Sun, Mar 09, 2008 at 01:55:15PM +0000, Joel Soete wrote:
> > > Hello Grant,
> > >
> > > Always tracking this ccio-dma bug, I figure out this stuff could be 
> > > helpfull:
> > > --- a/drivers/parisc/ccio-dma.c	2008-03-09 12:55:00.000000000 +0000
> > > +++ b/drivers/parisc/ccio-dma.c	2008-03-09 12:55:21.000000000 +0000
> > > @@ -802,7 +802,7 @@
> > >  			 * Hopefully someone figures out how to patch (NOP) the
> > >  			 * FDC/SYNC out at boot time.
> > >  			 */
> > > -			asm volatile("fdc %%r0(%0)" : : "r" (pdir_ptr[7]));
> > > +			asm volatile("fdc %%r0(%0)" : : "r" (pdir_ptr));
> > 
> > BTW, once you've tested/demostrated this fixes the DMA problems on C-xxx,
> > please resend with "Signed-off-by:" line.

The existing code is clearly wrong.  pdir_ptr[7] is not a pointer and
the previous statement sets it to zero to clear the valid bit.  So, don't
drop this line of investigation.

Dave
-- 
J. David Anglin                                  dave.anglin@xxxxxxxxxxxxxx
National Research Council of Canada              (613) 990-0752 (FAX: 952-6602)
--
To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux SoC]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux