Hi Javier, On Sat, Nov 16, 2013 at 06:28:00PM +0100, Javier Martinez Canillas wrote: > > The hack, as being sent by Javier, will result in the wrong > > regulator being used on the Nokia N900, which is using vaux1. > > It must depend on the machine. > > I see, so this hack is not generic enough to be usable for all OMAP3 boards so I > think is better to just add the hack on the DTS. > > I was more found about adding a hack on dpi.c since the DTB is an stable ABI > while the dpi.c implementation is not. I agree with this. My suggestion would be to get the vdds_dsi regulator name from platform data. This way each board can setup its own quirk until omapdss supports DT. > But I guess is not that bad to change the DTS later once DSS DT > bindings are added to mainline. As far as I know DT bindings are supposed to be as stable as possible. > > At the same time the N900 device tree file uses V28 as > > regulator-name for vaux1 (which is the same one as legacy boot > > used). Nothing depends on this, but I don't think it's a > > good idea to use this property. Apparently it does not work > > if multiple drivers need the same regulator under different > > names. > > > > -- Sebastian > > > > So, what do you think about the following patch instead? > > [PATCH] For Nokia N900 vaux1 is also used for si4713 radio chip, lis3lv02d accelerometer and battery cover sensor, so I don't like this hack. If vppl2 is only used for omapdss.dsi on IGEP boards it might be sensible to label it, though? So it might be ok there. -- Sebastian
Attachment:
signature.asc
Description: Digital signature
