On Sat, Nov 16, 2013 at 07:45:07AM -0800, Tony Lindgren wrote: > Well let's see what Tomi prefers. > > > > &vaux1 { > > > /* Needed for ads7846 */ > > > regulator-name = "vcc"; > > > }; > > > > > > &vpll2 { > > > /* Needed for DSS */ > > > regulator-name = "vdds_dsi"; > > > }; > > In the long we'll use regulator phandles anyways in the DSS related > nodes, so from that point of view fixing dpi.c makes sense. The hack, as being sent by Javier, will result in the wrong regulator being used on the Nokia N900, which is using vaux1. It must depend on the machine. At the same time the N900 device tree file uses V28 as regulator-name for vaux1 (which is the same one as legacy boot used). Nothing depends on this, but I don't think it's a good idea to use this property. Apparently it does not work if multiple drivers need the same regulator under different names. -- Sebastian
Attachment:
signature.asc
Description: Digital signature