RE: [RFC PATCH] i2c: omap: Clear ARDY bit twice

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> From: Taras Kondratiuk [mailto:taras.kondratiuk@xxxxxxxxxx]
> Sent: Wednesday, October 02, 2013 5:59 AM
> To: Balbi, Felipe
> Cc: Strashko, Grygorii; Woodruff, Richard; linux-omap@xxxxxxxxxxxxxxx; Taras
> Kondratiuk
> Subject: [RFC PATCH] i2c: omap: Clear ARDY bit twice
 
> Initially commit cb527ede1bf6ff2008a025606f25344b8ed7b4ac
> "i2c-omap: Double clear of ARDY status in IRQ handler"
> added a workaround for undocumented errata ProDB0017052.
> But then commit 1d7afc95946487945cc7f5019b41255b72224b70
> "i2c: omap: ack IRQ in parts" refactored code and missed one of ARDY
> clearings. So current code violates errata.
> It causes often i2c bus timeouts on my Pandaboard.

History of this was during OMAP3 a couple phone ramps were fixed with path.

Another SOC (non-OMAP) which uses same I2C IP had clear HW root cause in its integration to SOC.

When stuck at customer I went through other SOC erratas and tried them when OMAP did not work.

This was found to be robust and did exist in RTL versions used as such fix was accepted and used on most end customers in that time frame.

At 'that time' there was some internal process blockages around getting waveforms on OMAP integration which kept fix from sticking in errata.

Regards,
Richard W.

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux