On Friday 23 August 2013 11:00 AM, Sekhar Nori wrote: >> @@ -728,6 +736,44 @@ static void _cpsw_adjust_link(struct cpsw_slave *slave, >> > u32 mac_control = 0; >> > u32 slave_port; >> > >> > + if (priv->gmii_sel_reg && of_machine_is_compatible("ti,am33xx")) { > This sounds like the DT version of cpu_is_am335x()! Looks like you need > to introduce a new compatible "ti,am3352-cpsw" to indicate the AM3352 > specific features of the CPSW IP (yeah, control module is not really > part of the IP, but by introducing it in the driver, we are treating it > such anyway. And you can see this register as extension of IP since its > not shared for any other purpose). > I also agree but it should be ti,am3352-cpsw or ti.am33xx-cpsw? Regards Mugunthan V N -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html