Hi On 08/19/2013 11:51 AM, Julia Lawall wrote: > From: Julia Lawall <Julia.Lawall@xxxxxxx> > > Remove unneeded error handling on the result of a call to > platform_get_resource_byname when the value is passed to devm_ioremap_resource. > > In the case of omap-dmic.c, the error-handling code of > devm_ioremap_resource is also corrected to include releasing the clock. > > A simplified version of the semantic patch that makes this change is as > follows: (http://coccinelle.lip6.fr/) > > // <smpl> > @@ > expression pdev,res,e,e1; > expression ret != 0; > identifier l; > @@ > > res = platform_get_resource_byname(...); > - if (res == NULL) { ... \(goto l;\|return ret;\) } > e = devm_ioremap_resource(e1, res); > // </smpl> > > Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx> > > --- > sound/soc/omap/omap-dmic.c | 9 +++------ > sound/soc/omap/omap-mcpdm.c | 3 --- > 2 files changed, 3 insertions(+), 9 deletions(-) > To the patch and catch of missing clock release in omap-dmic.c in case of failing devm_ioremap_resource: Acked-by: Jarkko Nikula <jarkko.nikula@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
