* Grygorii Strashko <grygorii.strashko@xxxxxx> [130716 07:32]: > Hi Tony, > > On 07/16/2013 04:41 PM, Tony Lindgren wrote: > >* Grygorii Strashko <grygorii.strashko@xxxxxx> [130716 06:22]: > >>Hi Tony, > >> > >>This patch causes boot failure when I've applied my patch > >>"[RFC] ARM: OMAP2+: omap_device: add pinctrl handling" > >>https://lkml.org/lkml/2013/6/21/309 > >> > >>on top of it: > > > >Hmm this patch alone removes duplicate code and if it causes > >issues I must have made a typo somewhere. > > No typo :) You've removed the check for !dev-pins. Oh OK, sorry that was not intentional. > And the failure place is: > int pinctrl_pm_select_active_state(struct device *dev) > { > return pinctrl_pm_select_state(dev, dev->pins->active_state); > ^^^^ here > } > > If I understand everything right, the pinctrl support in Device core > assumed to be optional - so, It's valid case, when there are no > definition for device's pinctrl in DT at all. > > And in this case dev->pins == NULL and pinctrl_pm_select_*() API > should return 0 always. Care to post your patch as it sounds like you have it fixed and tested? Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
