Re: [PATCH] mmc: omap_hsmmc: use for OMAP5 as well

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jul 07, 2013 at 05:13:10PM -0300, Ezequiel Garcia wrote:
> Hi guys,
> 
> On Fri, Jun 28, 2013 at 09:27:20PM +0530, Balaji T K wrote:
> > On Friday 28 June 2013 06:04 PM, a-bindra@xxxxxx wrote:
> > > From: Amarinder Bindra <a-bindra@xxxxxx>
> > >
> > > OMAP's hs_mmc driver is also used for OMAP5 MMC controller operation.
> > > Considering that the device tree entries are already there for this,
> > > allow the driver to be built when only OMAP5 is enabled.
> > > This allows MMC root filesystems to be available in "OMAP5 only"
> > > configurations.
> > >
> > > Signed-off-by: Amarinder Bindra <a-bindra@xxxxxx>
> > > Acked-by: Felipe Balbi <balbi@xxxxxx>
> > > Acked-by: Nishanth Menon <nm@xxxxxx>
> > 
> > Looks good to me,
> > Acked-by: Balaji T K <balajitk@xxxxxx>
> > 
> 
> I came across this same issue while trying MMC patches on AM3xx,
> which is nor OMAP3 neither OMAP4.
> 
> Now, looking at the driver I don't see any OMAP-specific bits
> (welcome to the multiplatform world ;-) so I think we can just
> remove the 'depends' line. Something like this:

frankly speaking, this driver should be deleted and all users should be
moved to sdhci. OMAP's HSMMC controller is compatible with SDHCI except
for a couple quirks which can be easily worked around.

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux