On Mon 2013-07-01 22:22:21, Sergei Shtylyov wrote:
> Hello.
>
> On 07/01/2013 06:03 PM, Pavel Machek wrote:
>
> >Errata workarounds for N900 hardware actually break operation on
> >emulator. Fix it.
>
> >This approach was suggested by Pali Rohár <pali.rohar@xxxxxxxxx>
> >(thanks!).
>
> >(Also explain what "sleep_ind" led actually does).
>
> Looks like unrelated change and probably worth another patch?
Separate patch for adding single-line comment?
> >--- a/arch/arm/mach-omap2/board-rx51.c
> >+++ b/arch/arm/mach-omap2/board-rx51.c
> >@@ -33,9 +33,12 @@
> > #include "pm.h"
> > #include "sdram-nokia.h"
> > #include "board-rx51-secure.h"
> >+#include "soc.h"
> >
> > #define RX51_GPIO_SLEEP_IND 162
> >
> >+/* This lights up left part of keyboard */
> >+
> > static struct gpio_led gpio_leds[] = {
...
> > #ifdef CONFIG_ARM_ERRATA_430973
> >- printk(KERN_INFO "RX-51: Enabling ARM errata 430973 workaround.\n");
> >- /* set IBE to 1 */
> >- rx51_secure_update_aux_cr(1 << 6, 0);
> >+ if (omap_type() == OMAP2_DEVICE_TYPE_SEC) {
> >+ printk(KERN_INFO "RX-51: Enabling ARM errata 430973 workaround.\n");
>
> How about pr_info() instead?
<sarcasm>Would not that be unrelated change and worth of separate
patch?</sarcasm>
:-).
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
