Re: [PATCH] N900: fix operation on emulator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

On 07/01/2013 06:03 PM, Pavel Machek wrote:

Errata workarounds for N900 hardware actually break operation on
emulator. Fix it.

This approach was suggested by Pali Rohár <pali.rohar@xxxxxxxxx>
(thanks!).

(Also explain what "sleep_ind" led actually does).

   Looks like unrelated change and probably worth another patch?

Signed-off-by: Pavel Machek <pavel@xxxxxx>

diff --git a/arch/arm/mach-omap2/board-rx51.c b/arch/arm/mach-omap2/board-rx51.c
index 74f83a5..81f7b9f 100644
--- a/arch/arm/mach-omap2/board-rx51.c
+++ b/arch/arm/mach-omap2/board-rx51.c
@@ -33,9 +33,12 @@
  #include "pm.h"
  #include "sdram-nokia.h"
  #include "board-rx51-secure.h"
+#include "soc.h"

  #define RX51_GPIO_SLEEP_IND 162

+/* This lights up left part of keyboard */
+
  static struct gpio_led gpio_leds[] = {
  	{
  		.name	= "sleep_ind",
@@ -107,9 +110,11 @@ static void __init rx51_init(void)
  	rx51_camera_init();

  #ifdef CONFIG_ARM_ERRATA_430973
-	printk(KERN_INFO "RX-51: Enabling ARM errata 430973 workaround.\n");
-	/* set IBE to 1 */
-	rx51_secure_update_aux_cr(1 << 6, 0);
+	if (omap_type() == OMAP2_DEVICE_TYPE_SEC) {
+		printk(KERN_INFO "RX-51: Enabling ARM errata 430973 workaround.\n");

   How about pr_info() instead?

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux