Re: [PATCH v4 1/2] gpio/omap: don't create an IRQ mapping for every GPIO on DT

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jun 30, 2013 at 1:44 AM, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> On Fri, Jun 28, 2013 at 5:27 PM, Javier Martinez Canillas
> <javier.martinez@xxxxxxxxxxxxxxx> wrote:
>
>> When a GPIO is defined as an interrupt line using Device
>> Tree, a call to irq_create_of_mapping() is made that calls
>> irq_create_mapping(). So, is not necessary to do the mapping
>> for all OMAP GPIO lines and explicitly call irq_create_mapping()
>> on the driver probe() when booting with Device Tree.
>>
>> Add a custom IRQ domain .map function handler that will be
>> called by irq_create_mapping() to map the GPIO lines used as IRQ.
>> This also allows to execute needed setup code such as configuring
>> a GPIO as input and enabling the GPIO bank.
>>
>> Signed-off-by: Javier Martinez Canillas <javier.martinez@xxxxxxxxxxxxxxx>
>> Tested-by: Enric Balletbo i Serra <eballetbo@xxxxxxxxx>
>> Acked-by: Grant Likely <grant.likely@xxxxxxxxxxxx>
>> Acked-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@xxxxxxxxxxxx>
>> ---
>>
>> Changes since v3:
>>   - Use bank->chip.of_node instead of_have_populated_dt() to check
>>     DT or legacy boot as suggested by Jean-Christophe PLAGNIOL-VILLARD
>
> This does not apply to the "next" branch on my GPIO tree,
> i.e:
> https://git.kernel.org/cgit/linux/kernel/git/linusw/linux-gpio.git/
>
> Not even with fuzzing :-(
>
> Can you rebase them?
>
> Yours,
> Linus Walleij
> --

Hi Linus,

Yes, It doesn't apply cleanly to your "next" branch cleanly because
this patch-set depends on the following bugfix patch merged late on
the -rc cycle (3.10-rc7):

397eada9 ("gpio/omap: don't use linear domain mapping for OMAP1")

but your next branch is based on Linux 3.10-rc3.

So, I could change the patches so they can be applied cleanly on your
branch but then it will not apply cleanly when you send your pull
request to Torvalds.

Thanks a lot and best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux