Hi, On Wed, Jun 19, 2013 at 12:46 PM, Benoit Cousson <b-cousson@xxxxxx> wrote: > Hi Enric, > > > On 06/19/2013 03:27 AM, Enric Balletbo i Serra wrote: >> >> The IGEP COM AQUILA is industrial processors SODIMM module with >> following highlights: >> >> o AM3352/AM3354/AM3358/AM3359 Texas Instruments processor >> o Cortex-A8 ARM CPU >> o 3.3 volts Inputs / Outputs use industrial >> o 256 MB DDR3 SDRAM / 128 Megabytes FLASH >> o MicroSD card reader on-board >> o Ethernet controller on-board >> o JTAG debug connector available >> o Designed for industrial range purposes >> >> Signed-off-by: Enric Balletbo i Serra <eballetbo@xxxxxxxxxxx> >> --- >> arch/arm/boot/dts/am335x-igep0033.dtsi | 269 >> +++++++++++++++++++++++++++++++++ >> 1 file changed, 269 insertions(+) >> create mode 100644 arch/arm/boot/dts/am335x-igep0033.dtsi >> >> diff --git a/arch/arm/boot/dts/am335x-igep0033.dtsi >> b/arch/arm/boot/dts/am335x-igep0033.dtsi >> new file mode 100644 >> index 0000000..1d70141 >> --- /dev/null >> +++ b/arch/arm/boot/dts/am335x-igep0033.dtsi >> @@ -0,0 +1,269 @@ >> +/* >> + * Copyright (C) 2013 ISEE 2007 SL - http://www.isee.biz/ >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2 as >> + * published by the Free Software Foundation. >> + */ >> + >> +/dts-v1/; >> + >> +#include "am33xx.dtsi" >> + >> +/ { >> + cpus { >> + cpu@0 { >> + cpu0-supply = <&vdd1_reg>; >> + }; >> + }; >> + >> + memory { >> + device_type = "memory"; >> + reg = <0x80000000 0x10000000>; /* 256 MB */ >> + }; >> + >> + am33xx_pinmux: pinmux@44e10800 { > > > That node should be inside the ocp one since the control module is a regular > IP connected to the OCP interconnect. > > > In fact, I don't think that there should be a definition of the On Chip Peripherals interconnect or any child node of the ocp in a DTS file. These should be defined in the included dtsi file since it will be common to all boards based on this SoC. DTS files that describe a board can reference these nodes defined in the dtsi and add their custom peripherals as childs of them. So, instead defining in the DTS: am33xx_pinmux: pinmux@44e10800 { ... }; gpmc: gpmc@50000000 { ... }; i2c0: i2c@44e0b000 { ... }; uart0: serial@44e09000 { .. }; It has to be defined as: &am33xx_pinmux { ... }; &gpmc { ... }; &i2c0 { ... } I'm looking at other am33xx dts such as am335x-bone.dts and am335x-evm.dts and I see that these define device nodes already defined in the included .dtsi which is wrong in my opinion. The OMAP{3,4,5} dtsi and dts do correctly and can be used as a reference on how the device nodes have to be defined and referenced. Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
