On 06/10/2013 05:25 PM, Tony Lindgren wrote: > * Quadros, Roger <rogerq@xxxxxx> [130610 05:37]: >> Hi Tony, (sorry, on Outlook web) >> >> - compatible = "ti,omap4-padconf", "pinctrl-single"; >> + compatible = "ti,omap4-padconf"; >> >> This change is not necessary if we make sure the pinctrl-single-omap driver >> gets registered early enough, before the pinctrl devices are probed. >> (e.g. subsys_initcall()) > > I'd rather make everything just module_init, there should not be > any need to tinker with the init call ordering any longer with > deferred probe. And by making everything into regular device drivers > we actually see real error messages without DEBUG_LL and earlyprintk > if something goes wrong. > > Note that there are patches queued to make twl-core.c just regular > module_init as well, so that should fix any issues you might be > related it probing before pinctrl. > OK. >> I've commented about this in the other patch. > > Sorry can you clarify, which other patch? The other message I saw > in this thread was empty. Or at least I have not seen it yet. Sorry about that. Outlook web sucks. I see that you have found it :). cheers, -roger -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html