On Fri, Jun 07, 2013 at 04:00:22PM -0700, Tony Lindgren wrote: > In the runtime_suspend function pdata is not being used, and > also blocks the function in device tree based booting. Fix it > by removing the unused pdata from the runtime_suspend function. > > Further, context loss count is not being passed in pdata, so > let's just reinitialize the port every time for those case. > This can be further optimized later on for the device tree > case by adding detection for the hardware state and possibly > by adding a driver specific autosuspend timeout. > > And doing this, we can then make the related dev_err into a > dev_dbg message instead of an error. > > In order for the wake-up events to work, we also need to set > autosuspend_timeout to -1 if 0, and also device_init_wakeup() > as that's not being done by the platform init code for the > device tree case. > > Note that this does not affect legacy booting, and in fact > might make it work for the cases where the context loss info > is not being passed in pdata. > > Thanks to Kevin Hilman <khilman@xxxxxxxxxx> for debugging > and suggesting fixes for the autosuspend_timeout and > device_init_wakeup() related initializiation. > > Reviewed-by: Kevin Hilman <khilman@xxxxxxxxxx> > Tested-by: Kevin Hilman <khilman@xxxxxxxxxx> > Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx> > > --- > > Here's an updated version with the white space fixed. Since > you already acked it, I won't waste the opportunity to keep it > in a single patch :) It doesn't apply to my tree, so you'll have to refresh it against my tty-next tree and resend it. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
