Sorry for top posting. We should still drop the IRQ data for those devices and only retain DMA data in that case. Tony, can you please refresh your commit so that IRQ data is dropped from those devices ? Regards, Santosh ________________________________________ From: Tony Lindgren [tony@xxxxxxxxxxx] Sent: Saturday, June 08, 2013 12:57 PM To: R, Sricharan Cc: Shilimkar, Santosh; Paul Walmsley; linux-omap@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; Nayak, Rajendra; Cousson, Benoit; Kristo, Tero; K, Ambresh Subject: Re: [PATCH V2 14/14] ARM: OMAP4: hwmod data: Clean up the data file * Sricharan R <r.sricharan@xxxxxx> [130608 09:52]: > On Saturday 08 June 2013 12:14 AM, Santosh Shilimkar wrote: > > On Friday 07 June 2013 02:37 PM, Tony Lindgren wrote: > >> > >> Looking at the diff output with and without, it seems to be that the > >> DMA channels won't get configured. > >> > > That should work since DMA engine changes are in mainline and the > > DMA channel information is already in DT. > > > The issue is that mmc, spi drivers try to get the 'dma' request number from > get_platform_resource, which fails if hwmod has not populated the data. > > There are patches already from Balaji [1] for hsmmc, Matt Porter [2] mcspi > for adapting the drivers for Dma engine. Dma engine gets the data from DT. > > [1] http://comments.gmane.org/gmane.linux.kernel.mmc/20378 > [2] http://www.spinics.net/lists/linux-omap/msg87634.html > > [1] is already in mmc-next for 3.10 branch. > > Then one more patch for spi [3] is required for completing this. This is similar > to the patch done for mmc to skip the get_platform_resource call in case of DT. > > [3] http://www.mail-archive.com/linux-omap@xxxxxxxxxxxxxxx/msg90112.html OK thanks for looking into that. Once those driver changes hit mainline, please send a follow-up patch to remove the spi and mmc entries. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
