RE: [PATCH] ARM: dts: add dtsi for palmas

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Benoit,

Thanks for the quick response.
________________________________________
From: Cousson, Benoit
Sent: Friday, June 07, 2013 5:57 PM
To: J, KEERTHY
Cc: devicetree-discuss@xxxxxxxxxxxxxxxx; linux-omap@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; ldewangan@xxxxxxxxxx; grant.likely@xxxxxxxxxxxx; swarren@xxxxxxxxxxxxx; swarren@xxxxxxxxxx; sameo@xxxxxxxxxxxxxxx; gg@xxxxxxxxxxxxxxx; lee.jones@xxxxxxxxxx
Subject: Re: [PATCH] ARM: dts: add dtsi for palmas

Hi Keerthy,

On 06/07/2013 01:28 PM, J Keerthy wrote:
> Adds palmas mfd and palmas regulator nodes. This is
> based on the patch series:
>
> http://www.mail-archive.com/linux-omap@xxxxxxxxxxxxxxx/msg89957.html
>
> The device tree nodes are based on:
> https://lkml.org/lkml/2013/6/6/25

It looks like the board node to use palmas is missing? I cannot find it
in the previous series as well?

Yes. This is just the palmas.dtsi which will be included in the board file.

>
> Signed-off-by: J Keerthy <j-keerthy@xxxxxx>
> Signed-off-by: Graeme Gregory <gg@xxxxxxxxxxxxxxx>
> ---
>  arch/arm/boot/dts/palmas.dtsi |  171 +++++++++++++++++++++++++++++++++++++++++
>  1 files changed, 171 insertions(+), 0 deletions(-)
>  create mode 100644 arch/arm/boot/dts/palmas.dtsi
>
> diff --git a/arch/arm/boot/dts/palmas.dtsi b/arch/arm/boot/dts/palmas.dtsi
> new file mode 100644
> index 0000000..be631b5
> --- /dev/null
> +++ b/arch/arm/boot/dts/palmas.dtsi
> @@ -0,0 +1,171 @@
> +/*
> + * Copyright (C) 2013 Texas Instruments Incorporated - http://www.ti.com/
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + */
> +
> +#include <dt-bindings/interrupt-controller/irq.h>
> +
> +&palmas {
> +     compatible = "ti,palmas";
> +     interrupt-controller;
> +     #interrupt-cells = <2>;

The I2C address should be there as well. We used to put it in the board
file, but this is really an I2C device specific information and not
board specific in that case.

This again i will send another patch on top of the existing board
file. That will have the I2C address. This patch only adds the
standalone palmas.dtsi.

Regards,
Keerthy

Regards,
Benoit


> +
> +     palmas_pmic {
> +             compatible = "ti,palmas-pmic";
> +             interrupt-parent = <&palmas>;
> +             interrupts = <14 IRQ_TYPE_NONE>;
> +             interrupt-name = "short-irq";
> +
> +             ti,ldo6-vibrator;
> +
> +             regulators {
> +                     smps123_reg: smps123 {
> +                             regulator-name = "smps123";
> +                             regulator-min-microvolt = < 600000>;
> +                             regulator-max-microvolt = <1500000>;
> +                             regulator-always-on;
> +                             regulator-boot-on;
> +                     };
> +
> +                     smps45_reg: smps45 {
> +                             regulator-name = "smps45";
> +                             regulator-min-microvolt = < 600000>;
> +                             regulator-max-microvolt = <1310000>;
> +                             regulator-always-on;
> +                             regulator-boot-on;
> +                     };
> +
> +                     smps6_reg: smps6 {
> +                             regulator-name = "smps6";
> +                             regulator-min-microvolt = <1200000>;
> +                             regulator-max-microvolt = <1200000>;
> +                             regulator-always-on;
> +                             regulator-boot-on;
> +                     };
> +
> +                     smps7_reg: smps7 {
> +                             regulator-name = "smps7";
> +                             regulator-min-microvolt = <1800000>;
> +                             regulator-max-microvolt = <1800000>;
> +                             regulator-always-on;
> +                             regulator-boot-on;
> +                     };
> +
> +                     smps8_reg: smps8 {
> +                             regulator-name = "smps8";
> +                             regulator-min-microvolt = < 600000>;
> +                             regulator-max-microvolt = <1310000>;
> +                             regulator-always-on;
> +                             regulator-boot-on;
> +                     };
> +
> +                     smps9_reg: smps9 {
> +                             regulator-name = "smps9";
> +                             regulator-min-microvolt = <2100000>;
> +                             regulator-max-microvolt = <2100000>;
> +                             regulator-always-on;
> +                             regulator-boot-on;
> +                             ti,smps-range = <0x80>;
> +                     };
> +
> +                     smps10_reg: smps10 {
> +                             regulator-name = "smps10";
> +                             regulator-min-microvolt = <5000000>;
> +                             regulator-max-microvolt = <5000000>;
> +                             regulator-always-on;
> +                             regulator-boot-on;
> +                     };
> +
> +                     ldo1_reg: ldo1 {
> +                             regulator-name = "ldo1";
> +                             regulator-min-microvolt = <2800000>;
> +                             regulator-max-microvolt = <2800000>;
> +                             regulator-always-on;
> +                             regulator-boot-on;
> +                     };
> +
> +                     ldo2_reg: ldo2 {
> +                             regulator-name = "ldo2";
> +                             regulator-min-microvolt = <2900000>;
> +                             regulator-max-microvolt = <2900000>;
> +                             regulator-always-on;
> +                             regulator-boot-on;
> +                     };
> +
> +                     ldo3_reg: ldo3 {
> +                             regulator-name = "ldo3";
> +                             regulator-min-microvolt = <3000000>;
> +                             regulator-max-microvolt = <3000000>;
> +                             regulator-always-on;
> +                             regulator-boot-on;
> +                     };
> +
> +                     ldo4_reg: ldo4 {
> +                             regulator-name = "ldo4";
> +                             regulator-min-microvolt = <2200000>;
> +                             regulator-max-microvolt = <2200000>;
> +                             regulator-always-on;
> +                             regulator-boot-on;
> +                     };
> +
> +                     ldo5_reg: ldo5 {
> +                             regulator-name = "ldo5";
> +                             regulator-min-microvolt = <1800000>;
> +                             regulator-max-microvolt = <1800000>;
> +                             regulator-always-on;
> +                             regulator-boot-on;
> +                     };
> +
> +                     ldo6_reg: ldo6 {
> +                             regulator-name = "ldo6";
> +                             regulator-min-microvolt = <1500000>;
> +                             regulator-max-microvolt = <1500000>;
> +                             regulator-always-on;
> +                             regulator-boot-on;
> +                     };
> +
> +                     ldo7_reg: ldo7 {
> +                             regulator-name = "ldo7";
> +                             regulator-min-microvolt = <1500000>;
> +                             regulator-max-microvolt = <1500000>;
> +                             regulator-always-on;
> +                             regulator-boot-on;
> +                     };
> +
> +                     ldo8_reg: ldo8 {
> +                             regulator-name = "ldo8";
> +                             regulator-min-microvolt = <1500000>;
> +                             regulator-max-microvolt = <1500000>;
> +                             regulator-always-on;
> +                             regulator-boot-on;
> +                     };
> +
> +                     ldo9_reg: ldo9 {
> +                             regulator-name = "ldo9";
> +                             regulator-min-microvolt = <1800000>;
> +                             regulator-max-microvolt = <3300000>;
> +                             regulator-always-on;
> +                             regulator-boot-on;
> +                     };
> +
> +                     ldoln_reg: ldoln {
> +                             regulator-name = "ldoln";
> +                             regulator-min-microvolt = <1800000>;
> +                             regulator-max-microvolt = <1800000>;
> +                             regulator-always-on;
> +                             regulator-boot-on;
> +                     };
> +
> +                     ldousb_reg: ldousb {
> +                             regulator-name = "ldousb";
> +                             regulator-min-microvolt = <3250000>;
> +                             regulator-max-microvolt = <3250000>;
> +                             regulator-always-on;
> +                             regulator-boot-on;
> +                     };
> +             };
> +     };
> +};
>

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux