Re: [PATCH] OMAPDSS: Remove kfree for memory allocated with devm_kzalloc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Wednesday 05 June 2013 10:59 PM, Emil Goode wrote:
It's not necessary to free memory allocated with devm_kzalloc
in a remove function and using kfree leads to a double free.

Looks fine to me. Tomi, could you take this for 3.11?

Archit


Signed-off-by: Emil Goode <emilgoode@xxxxxxxxx>
---
  drivers/video/omap2/displays/panel-picodlp.c |    2 --
  1 file changed, 2 deletions(-)

diff --git a/drivers/video/omap2/displays/panel-picodlp.c b/drivers/video/omap2/displays/panel-picodlp.c
index 62f2db0..859e111 100644
--- a/drivers/video/omap2/displays/panel-picodlp.c
+++ b/drivers/video/omap2/displays/panel-picodlp.c
@@ -469,8 +469,6 @@ static void picodlp_panel_remove(struct omap_dss_device *dssdev)
  	i2c_unregister_device(picod->picodlp_i2c_client);
  	dev_set_drvdata(&dssdev->dev, NULL);
  	dev_dbg(&dssdev->dev, "removing picodlp panel\n");
-
-	kfree(picod);
  }

  static int picodlp_panel_enable(struct omap_dss_device *dssdev)


--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux