Re: [net-next PATCH 1/8] drivers: net: phy: at803x code cleanup on register and unregister driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

On 04-06-2013 10:10, Mugunthan V N wrote:

Make use of phy_drivers_register/phy_drivers_unregister to register/unregister
multiple phy drivers in a single module.

Cc: Matus Ujhelyi <ujhelyi.m@xxxxxxxxx>
Signed-off-by: Mugunthan V N <mugunthanvnm@xxxxxx>
---
  drivers/net/phy/at803x.c |   35 ++++++++++-------------------------
  1 file changed, 10 insertions(+), 25 deletions(-)

diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
index 45cbc10..a1063e1 100644
--- a/drivers/net/phy/at803x.c
+++ b/drivers/net/phy/at803x.c
@@ -108,8 +108,9 @@ static int at803x_config_init(struct phy_device *phydev)
  	return 0;
  }

-/* ATHEROS 8035 */
-static struct phy_driver at8035_driver = {
+static struct phy_driver at803x_driver[] = {
+{
+	/* ATHEROS 8035 */
  	.phy_id		= 0x004dd072,
  	.name		= "Atheros 8035 ethernet",
  	.phy_id_mask	= 0xffffffef,

    That's improper indentation. Needs to be shifted by one tab.

@@ -136,32 +135,18 @@ static struct phy_driver at8030_driver = {
  	.driver		= {
  		.owner = THIS_MODULE,
  	},
-};
+} };

   Looks ugly...

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux