On 30/05/13 14:12, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 12:34 Thu 30 May , Tomi Valkeinen wrote: >> On some platforms DPI requires a regulator to be enabled to power up the >> output pins. This regulator is, for some reason, currently attached to >> the virtual omapdss device, instead of the DPI device. This does not >> work for DT, as the regulator mappings need to be described in the DT >> data, and the virtual omapdss device is not present there. >> >> Fix the issue by acquiring the regulator in the DPI device. To retain >> compatibility with the current board files, the old method of getting >> the regulator is kept. The old method can be removed when the board >> files have been changed to pass the regulator to DPI. > > as discuss with Arnd we should handle regular enable and disable at device > probe for every device as we do for pinctrl I'm not sure what you mean. Enable of what? The regulator? Why would we enable it in the device's probe, as the device may never even be used? Or do you mean regulator_get()? Doing that in DPI driver's probe is problematic, as not all boards have any panels using DPI, and thus they may not have the regulator set up, but all boards have the DPI device added automatically. So for those boards the DPI probe would fail, always, if we tried to get the regulator. Tomi
Attachment:
signature.asc
Description: OpenPGP digital signature
