Re: [net-next resend PATCH 1/6] net: cpsw: enhance pinctrl support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: "Hebbar, Gururaja" <gururaja.hebbar@xxxxxx>
Date: Thu, 23 May 2013 11:28:38 +0000

> On Thu, May 23, 2013 at 12:27:41, David Miller wrote:
>> From: Mugunthan V N <mugunthanvnm@xxxxxx>
>> Date: Tue, 21 May 2013 15:24:58 +0530
>> 
>> > +		priv->pins_default = pinctrl_lookup_state(priv->pinctrl,
>> > +						PINCTRL_STATE_DEFAULT);
>> 
>> This is not indented correctly.
>> 
>> Argument on the second, and subsequent, lines of a function call
>> must start at the first column after the openning parenthesis of
>> the function call itself.
> 
> Well, if I am correct, doing so will make the line cross 80 character limit.
> If you could (please I ask), can you let me know how it can be handled in 
> above situation. I will make the changes/corrections and re-send it.
> 
> Thanks a lot in advance.

Avoid the deep indentation by coding the basic block into a helper
function.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux