* Santosh Shilimkar <santosh.shilimkar@xxxxxx> [130419 07:43]: > On Friday 19 April 2013 07:35 PM, Kevin Hilman wrote: > > Santosh Shilimkar <santosh.shilimkar@xxxxxx> writes: > > > >> On Friday 19 April 2013 06:19 AM, Jon Hunter wrote: > >>> > >>> On 04/18/2013 07:34 PM, Jon Hunter wrote: > >>>> > >>>> On 04/18/2013 06:10 PM, Jon Hunter wrote: > >>>>> On 04/18/2013 04:34 PM, Kevin Hilman wrote: > >>>> > >>>> ... > >>>> > >>>>>> Why not just init context right here if bank->loses_context && > >>>>>> !bank->context_valid? > >>>> > >>>> I really like this idea a lot. It can really clean-up the code > >>>> and really make it much more readable. Before we were playing > >>>> some tricks with when we init'ed the get_context_loss_count() > >>>> function pointer. How about the below? > >>>> > >>>> Tony, care to re-test? Still works thanks: Tested-by: Tony Lindgren <tony@xxxxxxxxxxx> > > Assuming this driver could become a module someday (not terribly likely, > > I know), but context_valid would have meaning for each module reload. > > > I don't think GPIO can ever be a module(at least on OMAP) considering the way > it is used in many SOCs and hence the objection on that flag. GPIO is really > an infrastructure driver which is needed to be always available for the > client drivers to work. Not really related to this fix.. But when booting with initramfs, we should be able to make everything into loadable modules except things that are related to enabling timers and interrupts. This is important for distros to be able do generic kernels. Surely for mounting non-initramfs root GPIO is most likely needed though :) Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
