On 04/05/2013 02:48 AM, Javier Martinez Canillas wrote: > According to Documentation/devicetree/bindings/interrupt-controller/interrupts.txt > the "#interrupt-cells" property of an "interrupt-controller" is used > to define the number of cells needed to specify a single interrupt. > > A commonly used variant is two cell on which #interrupt-cells = <2> > and the first cell defines the index of the interrupt in the controller > and the second cell is used to specify any of the following flags: > > - bits[3:0] trigger type and level flags > 1 = low-to-high edge triggered > 2 = high-to-low edge triggered > 4 = active high level-sensitive > 8 = active low level-sensitive > > An example of an interrupt controller which use the two cell format is > the OMAP GPIO controller that allows GPIO lines to be used as IRQ > (Documentation/devicetree/bindings/gpio/gpio-omap.txt) > > But setting #interrupt-cells = <2> on the OMAP GPIO device node and > specifying the GPIO-IRQ type and level flags on the second cell does not > store this value on the populated IORESOURCE_IRQ struct resource. > > This is because when using an IRQ from an interrupt controller and > setting both cells (e.g:) > > interrupt-parent = <&gpio6>; > interrupts = <16 8>; > > A call to of_irq_to_resource() is made and this function calls to > irq_of_parse_and_map_type() to get the virtual IRQ mapped to the real > index for this interrupt controller. This IRQ number is populated on > the struct resource: > > int of_irq_to_resource(struct device_node *dev, int index, struct resource *r) > { > int irq = irq_of_parse_and_map(dev, index); > .. > r->start = r->end = irq; > } > > irq_of_parse_and_map() calls to irq_create_of_mapping() which calls to > the correct xlate function handler according to "#interrupt-cells" > (irq_domain_xlate_onecell or irq_domain_xlate_twocell) and to > irq_set_irq_type() to set the IRQ type. > > But the type is never returned so it can't be saved on the IRQ struct > resource flags member. > > This means that drivers that need the IRQ type/level flags defined in > the DT won't be able to get it. But the interrupt controllers that need the information should be able to get to it via irqd_get_trigger_type. What problem exactly are you trying to fix? What driver would use this? My understanding of the IORESOURCE_IRQ_xxx (and DMA) bits are they are ISA specific and therefore should not be used on non-ISA buses. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html